-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Some fixes to make Spyder work with the latest changes in PyLSP #19969
Conversation
subrepo: subdir: "external-deps/python-lsp-server" merged: "5c37673ce" upstream: origin: "https://github.com/python-lsp/python-lsp-server.git" branch: "develop" commit: "5c37673ce" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
That's because we can't handle docs in Markdown.
Also add it to the requirements of our Mac app
3077cb2
to
718ec0e
Compare
718ec0e
to
90e4f8d
Compare
# Install docstring-to-markdown until we release PyLSP 1.6.0 | ||
mamba install docstring-to-markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalthviz, this needs to be removed when updating our dependencies before releasing 5.4.0.
# Install docstring-to-markdown until we release PyLSP 1.6.0 | ||
pip install docstring-to-markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this.
@@ -1,5 +1,6 @@ | |||
# Spyder extra packages | |||
autopep8 | |||
docstring-to-markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this.
@spyder-ide/core-developers, after this PR you need to install |
Under what circumstances with this cause Spyder to crash? |
That package is a direct dependency of PyLSP 1.6.0, which I just released. The thing is Spyder imports a little function from a PyLSP module which happens to also import |
Okay. Since it's not an optional dependency (plugin) for python-lsp-server, it does not need to be specified in the macOS extra packages (although there is no harm). |
Correct. I had to add |
Description of Changes
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12