Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add fallback validation for package wheels (Windows installer) #18849

Closed
wants to merge 1 commit into from

Conversation

dalthviz
Copy link
Member

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Workaround to check if wheels are available due to pypi/warehouse#11949

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@pep8speaks
Copy link

pep8speaks commented Jul 28, 2022

Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 196:80: E501 line too long (85 > 79 characters)

Comment last updated at 2022-07-28 20:34:54 UTC

@dalthviz dalthviz self-assigned this Jul 28, 2022
@dalthviz dalthviz added this to the v5.3.3 milestone Jul 28, 2022
@dalthviz dalthviz force-pushed the win_installer_wheels_check branch from 2deb3dd to feeafc1 Compare July 28, 2022 20:22
@dalthviz dalthviz force-pushed the win_installer_wheels_check branch from feeafc1 to fc6cfa1 Compare July 28, 2022 20:34
@dalthviz
Copy link
Member Author

Seems like pynsist also depends on yarg to download and check wheels availability so this doesn't work and we need to wait for CDN PyPI purge

@dalthviz dalthviz closed this Jul 28, 2022
@dalthviz dalthviz removed this from the v5.3.3 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants