-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Use an instance of SimpleCodeEditor to print files (Editor) #18808
Conversation
This allows us to always use a light syntax highlighting theme when printing.
As you can see, I decided to use the IDLE theme for this because I think it's the sharpest one among the light themes we have, but I'm not so sure about it. @dalthviz, what do you think? |
Should there be an option/preference to enable choosing which light theme to use when printing? Besides that I'm not sure which could be the best light theme. Maybe we could check which light theme provides the most contrast or some other measure to make a decision. |
I thought about that, but I think we can leave it for another PR in case users ask for it.
That's what I did and concluded that the best one is IDLE. Could you do the same and tell me what you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! Checking locally on Windows seems like this is working as expected 👍
Regarding the syntax theme, checked with this page (https://webaim.org/resources/contrastchecker/) the contrast between the themes colors (as foreground) and #ffffff
(as background) and seems like Scintilla
has better contrast mostly since IDLE
has the #ff7700
color which fails the check (even with bold letters).
Just in case this is how they look in comparison (Scintilla
left, IDLE
right):
So what do you think?
Great thinking! I'll change it to use the |
Description of Changes
This allows us to always use a light syntax highlighting theme when printing.
The
Print preview
looks like this nowIssue(s) Resolved
Fixes #2521.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12