PR: Stop IPython console channels faster #10085
Conversation
| @@ -504,7 +504,7 @@ def shutdown(self): | |||
| self.shellwidget.spyder_kernel_comm.close() | |||
| self.shellwidget.kernel_manager.shutdown_kernel(now=now) | |||
| if self.shellwidget.kernel_client is not None: | |||
| self.shellwidget.kernel_client.shutdown() | |||
There was a problem hiding this comment.
What's the difference between shutdown and stop_channels?
There was a problem hiding this comment.
Also, please remove the background function defined on the top of this file because it's not used anymore.
There was a problem hiding this comment.
shutdown stops the kernel, but is already called in self.shellwidget.kernel_manager.shutdown_kernel(now=now). stop_channels stops the channels, including the heartbeat channel. If the heartbeat channel is not stopped but the kernel is down, the channel will notice and send WARNING:traitlets:kernel died: 18.0
|
There was still a problem where spyder would hang if closing while closing a console. It is solved here: jupyter/jupyter_client#470. |
There was a problem hiding this comment.
Thanks a lot @impact27 for all your efforts to improve this!
ccordoba12
changed the title
ccordoba12
changed the title
Description of Changes
This avoids messages of the type
WARNING:traitlets:kernel died: 18.0that are created by #10066. I forgot that I already solved this problem in jupyter/jupyter_client#420, so I added a dependency on jupyter_client 5.2.5+.Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: