PR: Make QMenu.addAction and QToolBar.addAction compatible with Qt6 arguments' order
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atible_with_Qt6 # Conflicts: # qtpy/_utils.py
|
The tests have failed, but that's not my fault. |
|
Yep, the failing errors in the CI are unrelated to this and should be fixed after we merge #443 |
|
Just merged #443 . Updating the branch again with the base branch should make the CI pass 👍 |
|
Yeah, that's more like it. I'm sorry I haven't looked through the other pending PRs. The tests have indeed become much faster with |
dalthviz
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, I've stumbled upon that in Qt5 and Qt6,
addActionaccepts arguments in different order. So, here's the monkey patch for that.I've checked other derivatives of
QWidget, and onlyQMenu,QToolBar, andQLineEdithave non-trivialaddAction. I haven't patched the latter, for it hasn't changed between Qt5 and Qt6. So, this is the patch forQMenuandQToolBar.I don't actually know how to use the
receiver: QObjectand themember: bytesarguments ofaddAction, so I haven't tested them.