Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add pyproject.toml #9

Merged
merged 4 commits into from
Nov 6, 2023
Merged

PR: Add pyproject.toml #9

merged 4 commits into from
Nov 6, 2023

Conversation

jsbautista
Copy link
Collaborator

@jsbautista jsbautista commented Oct 23, 2023

Description of Changes

Add pyproject.toml file

Issue(s) Resolved

Fixes #7

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

@dalthviz dalthviz added the task Maintenance work label Oct 23, 2023
@dalthviz dalthviz added this to the v0.1.0 milestone Oct 23, 2023
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista ! I think the only missing thing here is to remove the setup.py file

@dalthviz dalthviz changed the title PR: Add pyproject.toml PR: Add pyproject.toml Oct 23, 2023

[tool.setuptools]
license-files = ["LICENSE"]
include-package-data = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, for more info about the CI error you can check this: https://stackoverflow.com/a/72547402/15954282

@jsbautista jsbautista requested a review from dalthviz November 6, 2023 18:10
@dalthviz dalthviz closed this Nov 6, 2023
@dalthviz dalthviz reopened this Nov 6, 2023
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dalthviz dalthviz merged commit f2b1f3b into spyder-ide:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pyproject.toml definition instead of setup.py
2 participants