build scala-extensions for 2.11 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Awesome, something I totally meant to do to get https://github.com/michaeldfallen/sbt-mustache to work for scala 2.11 |
|
Woops, what's happened to the build? Seems like a JDK version issue. |
|
It looks like Travis failed due to JDK version. The new travis build seems to be completing successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a target for
scala-extensionsto compile with version 2.11. Note that I opted to keep the current build structure of havingscala-extensions-{version}and just copied the code to get it working, which didn't require any changes. I am usually very reluctant to copy code and the craftsman in me wants me to change the build so sbt will cross-compile the same code for different scala targets, but I assume the structure is there to be able to handle version differences so I went with this one for now. The only change required was to updatecom.twitter.util-coreto the latest version, which has a 2.11 build available.