Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zed gateway twig related performance fix #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nidhognit
Copy link
Contributor

Description:

Related to FRW-2464 point 4

For now, we have one twig-related plugin for ZED and for the Gateway.
Each time when you render something in the gateway (like email sending) we also render full zed navigation.
More navigation systems have in ZED - slower emails that customers trigger from YVES.

Sometimes it takes up to 80% execution time.

This new plugin ZedGatewayTwigApplicationPlugin should be injected instead of TwigApplicationPlugin in the src/Pyz/Zed/Application/ApplicationDependencyProvider::getBackendGatewayApplicationPlugins()

Example:
image

@PhilinTv
Copy link
Contributor

@Nidhognit good catch! I though we dropped all UI dependencies in ZED from nonUI apps.

Is that possible to avoid adding this plugin in the first place?
This plugin look like a cheesy patch to the actual issue 🧀 .

…tion/ZedGatewayTwigApplicationPlugin.php

Co-authored-by: Denis Turkov <[email protected]>
@Nidhognit
Copy link
Contributor Author

@PhilinTv spryker has one plugin stack for ZED and for the GATEWAY, the only way to not initiate it - is to have a separate plugin stack for GATEWAY, or to have some logic inside the plugin itself.
I'm not sure if separating them will be a good or a bad decision, but it will definitely be a BC break change.
So yes, I have a bit of a cheesy fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants