Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache for the ACL entity rule check #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nidhognit
Copy link
Contributor

Description

The problem for this fix is described in the FRW-2464 point 2

In the merchant portal, we create rules on the fly for each entity each time
If you load 25 products, and join them with prices, stores, translations, etc. you can easily ~1.5 million checks

It would be strange if rules were changed in the middle of execution, and there is no way to change them on the fly.
But we spend 50%-80% of execution time for these checks

This fix solved the issue.
Should be patch

Example
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant