Fix support for Algorithm none
#624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobward
requested review from
sbihel,
timothee-haudebourg,
Ryanmtate and
Joey-Silberman
lucab
approved these changes
Oct 30, 2024
| @@ -26,7 +26,7 @@ macro_rules! algorithms { | |||
| /// | |||
| /// Per the specs it should only be `none` but `None` is kept for backwards | |||
There was a problem hiding this comment.
It would be nice to have a test to check that it serializes as none and that it is able to deserialize both.
There was a problem hiding this comment.
Good call, it was serializing to None.
sbihel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
Algorithm::Nonedeserialization. Currently"none"is rejected.Other changes
N/A
Tested
N/A