Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JOSE VC/VP signature format. #586

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Add JOSE VC/VP signature format. #586

merged 3 commits into from
Jul 26, 2024

Conversation

timothee-haudebourg
Copy link
Contributor

@timothee-haudebourg timothee-haudebourg marked this pull request as ready for review July 25, 2024 15:05
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. A couple of questions:

@timothee-haudebourg timothee-haudebourg merged commit d6d7737 into main Jul 26, 2024
4 checks passed
@timothee-haudebourg timothee-haudebourg deleted the vc-jose-cose branch July 26, 2024 10:25
@timothee-haudebourg
Copy link
Contributor Author

Is https://github.com/w3c/vc-jose-cose-test-suite/ any relevant to add additional tests?

Probably, but I think it will be more useful when we'll have the sd-jwt part of jose-cose implemented

Do you think there's a way of better integrating with JsonCredentialOrJws or should the user simply manually decode the JWS?

I'm not sure yet. There are two JWS signature formats for VC, one defined in VCDM1.1 (JWT-VC) and used by JsonCredentialOrJws, and one in JOSE-COSE for VCDM2.0. If we really need it we could add a similar JsonCredentialOrJws type in the v2 module, but having a single type that can make the distinction between JWT-VC and JOSE-COSE will require some more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants