Fixed #2 (Make MongoDB port configurable) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making the changes! It looks all good. In-terms of tagged releases if they were to be used I would like to keep the inline with Learning Lockers versions instead. You can always just do a |
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zapur1 !
Following up from the ticket I've opened yesterday, I went on and modified the entrypoint script to allow a custom MongoDB port to be passed. I also had (for some reason!) to install a couple of extra PHP extensions or
docker buildwouldn't complete successfully.I have tested this locally and it works as it should. Do you think it would be possible to review, merge this, release an updated (possibly tagged) image on Docker Hub? Many thanks!
cc @Filib