Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add mechanism for flagging that a request is within multitenanted context #58

Merged
merged 6 commits into from
Nov 17, 2024

Conversation

ollieread
Copy link
Member

This PR adds a flag for marking the current request as being within multitenanted context. This is primarily so that automated implicit functionality can be skipped if it shouldn't be running.

Fixes both #56 and #57

@ollieread ollieread added the type: fix Fix for a bug or other issue label Nov 17, 2024
@ollieread ollieread self-assigned this Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@825fa01). Learn more about missing BASE report.
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Overrides/SessionOverride.php 47.36% 10 Missing ⚠️
src/Sprout.php 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage        ?   86.80%           
  Complexity      ?      379           
=======================================
  Files           ?       57           
  Lines           ?     1091           
  Branches        ?        0           
=======================================
  Hits            ?      947           
  Misses          ?      144           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ollieread ollieread changed the title feat: Add mechanism for flagging that its within multitenanted context feat: Add mechanism for flagging that a request is within multitenanted context Nov 17, 2024
@ollieread ollieread merged commit 2abfc25 into main Nov 17, 2024
2 checks passed
@ollieread ollieread deleted the feat/tenant-context-flag branch November 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Fix for a bug or other issue
Projects
None yet
1 participant