Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused dynamic fees support #335

Merged
merged 14 commits into from
Feb 13, 2024
Merged

fix: remove unused dynamic fees support #335

merged 14 commits into from
Feb 13, 2024

Conversation

MakMuftic
Copy link
Contributor

@MakMuftic MakMuftic commented Jan 31, 2024 •
edited
Loading

As result of my effort to implement #334 directly into SDK, made some small changes that I would leave here:

  • util function that checks if the route exists from source chain router
  • removed the old dynamic fee code as it is not relevant anymore

Related Issue Or Context

How Has This Been Tested? Testing details.

  • Expanded unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

mpetrunic
mpetrunic requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add method to get all available destination networks and filterable with route asset type
  • update lockfile^^

wainola
wainola suggested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@wainola wainola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@MakMuftic MakMuftic changed the title feat: Add ability to query available resources on specific route feat: Add ability to query that specific route exists Feb 8, 2024
@MakMuftic MakMuftic requested a review from wainola February 8, 2024 13:11
@MakMuftic MakMuftic changed the title feat: Add ability to query that specific route exists chore: Remove dynamic fees support Feb 12, 2024
@mpetrunic
Copy link
Member

ci^^

@mpetrunic
fix lint
98408fa 
Signed-off-by: Marin Petrunic <[email protected]>
@mpetrunic
fix build
48dfd31 
Signed-off-by: Marin Petrunic <[email protected]>
mpetrunic
mpetrunic previously approved these changes Feb 13, 2024
View reviewed changes
@mpetrunic mpetrunic changed the title chore: Remove dynamic fees support fix: remove unused dynamic fees support Feb 13, 2024
mpetrun5
mpetrun5 previously approved these changes Feb 13, 2024
View reviewed changes
@MakMuftic MakMuftic dismissed stale reviews from mpetrun5 and mpetrunic via 423bed9 February 13, 2024 16:33
@MakMuftic MakMuftic merged commit 63302fd into main Feb 13, 2024
3 checks passed
@MakMuftic MakMuftic deleted the mmuftic/query-routes branch February 13, 2024 18:22
@MakMuftic MakMuftic mentioned this pull request Feb 13, 2024
Merged
mpetrunic pushed a commit that referenced this pull request Feb 14, 2024
@MakMuftic
chore(main): release sygma-sdk-core 2.7.0 (#343)
d1052ac 
🤖 I have created a release *beep* *boop*
---


##
[2.7.0](sygma-sdk-core-v2.6.3...sygma-sdk-core-v2.7.0)
(2024-02-14)


### Features

* add routes details and domain metadata helper functions
([#340](#340))
([1145e68](1145e68))


### Bug Fixes

* getTransferStatusData
([#342](#342))
([724ea2f](724ea2f))
* remove unused dynamic fees support
([#335](#335))
([63302fd](63302fd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wainola wainola wainola approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@nmlinaric nmlinaric nmlinaric approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MakMuftic @mpetrunic @wainola @mpetrun5 @nmlinaric