Chore/upgrade gradle #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/upgrading_version_6.html#removal_of_the_legacy_maven_plugin) -equalize spring boot version to prevent conflicts/build errors -remove obsolete testCompile steps
|
That's an unexpected and very nice contribution, thanks! I just have to check if the publishing plugins work correctly with the new version, I remember trying to upgrade to Gradle 6 and they didn't work properly. |
|
We were fiddling around in our team and I thought I might as wel create a PR with the improvements. Local publishing gives the following error : But I think that is expected. Let me know whether I can also help out here. The project saved us so much time that I can spent some more on it 😄 |
|
Everything works great 😃 And it's nice to hear it saved you time, thanks again for the PR |
stavshamir
added a commit
that referenced
this pull request
Jun 18, 2022
This reverts commit f92284c. The upgraded version does not sign releases correctly.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle is upgraded to a more recent version with the command
./gradlew wrapper --gradle-version 7.4.2The maven plugin is deprecated since gradle 7 and thus removed : https://docs.gradle.org/7.0/userguide/upgrading_version_6.html#removal_of_the_legacy_maven_plugin
Some
testCompilesteps were now giving errors, but they could be safely removedEqualized the spring boot version because of an error with
2.1.1: "property 'bootInf' is missing an input or output annotation" spring-projects/spring-boot#18326