(fix): added annotation for google pubsub message binding #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for springwolf-ui canceled.
|
timonback
reviewed
Apr 1, 2024
...n/java/io/github/springwolf/examples/cloudstream/configuration/CloudstreamConfiguration.java
Show resolved
Hide resolved
...s/springwolf-googlepubsub-binding/src/test/java/GooglePubSubMessageBindingProcessorTest.java
Show resolved
Hide resolved
...b/springwolf/bindings/googlepubsub/annotations/channels/GooglePubSubAsyncChannelBinding.java
Outdated
Show resolved
Hide resolved
…ding from auto-configuration
sam0r040
reviewed
Apr 5, 2024
...ngwolf/bindings/googlepubsub/annotations/channels/GooglePubsubAsyncMessageStoragePolicy.java
Outdated
Show resolved
Hide resolved
sam0r040
reviewed
Apr 5, 2024
...ub/springwolf/bindings/googlepubsub/annotations/messages/GooglePubSubAsyncMessageSchema.java
Outdated
Show resolved
Hide resolved
|
Nice addition and improvement of Google PubSub Message bindings. We commented on two things. |
…t and retention annotation
timonback
approved these changes
Apr 6, 2024
|
Hi @SheheryarAamir, In the end I arrived at SheheryarAamir#1 EDIT: I was able to cherry-pick and push it to this branch. Hopefully, the tests are green. I will merge it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added annotation for google pubsub message binding