-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BiConsumer to spring cloud stream plugin #1077
Add BiConsumer to spring cloud stream plugin #1077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Springwolf. Thanks a lot for creating your first pull request. Please check out our contributors guide and feel free to join us on discord.
✅ Deploy Preview for springwolf-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I haven't yet used the |
springwolf-examples/springwolf-cloud-stream-example/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
springwolf-examples/springwolf-cloud-stream-example/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
The change looks good to me, even when headers are not supported yet, it is a step in the right direction. Have a look at the publishing functionality, if there is no cloudstream way available, then lets leave it (+ useFqn) unchanged. |
@timonback one could use the But I'm not completely sure whether this works because the other direction is required. |
I like the change, it seems to be cloud-stream way. Regarding the base-package: I think it is fair to assume that the Function must be declared in a specific package (which I hope can be inferred through the type). (Assuming: The information where the Function is defined as a bean is lost) (Is a dependency required? I am not able to autowire it in the cloudstream-example.) |
Looks like an interesting starting point to browse the docs. Could be a future enhancement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @LeovR. I've run the pipelines, can you check the tests?
* Add BiConsumer to spring cloud stream plugin
This addresses #1071 but only adds the
BiConsumer
.