Skip to content

Commit

Permalink
jaegerreceiver: migrate to latest semconv version (open-telemetry#35237)
Browse files Browse the repository at this point in the history
Description: The version of semconv is upgraded from to v1.6.1 to
v1.27.0

The semconv attributes' value have been compared using
[go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator)
resulting in relevant 0 diffs.

Link to tracking Issue:
open-telemetry#22095

Testing: Tests passed
  • Loading branch information
narcis96 authored and jriguera committed Oct 4, 2024
1 parent 097b415 commit 9efafed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion receiver/jaegerreceiver/jaeger_agent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
"go.opentelemetry.io/collector/consumer/consumertest"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/collector/receiver/receivertest"
conventions "go.opentelemetry.io/collector/semconv/v1.6.1"
conventions "go.opentelemetry.io/collector/semconv/v1.27.0"
"google.golang.org/grpc"

"github.com/open-telemetry/opentelemetry-collector-contrib/internal/common/testutil"
Expand Down
10 changes: 5 additions & 5 deletions receiver/jaegerreceiver/trace_receiver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/ptrace"
"go.opentelemetry.io/collector/receiver/receivertest"
conventions "go.opentelemetry.io/collector/semconv/v1.6.1"
conventions "go.opentelemetry.io/collector/semconv/v1.27.0"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials"
"google.golang.org/grpc/credentials/insecure"
Expand Down Expand Up @@ -306,8 +306,8 @@ func grpcFixture(t *testing.T, t1 time.Time, d1, d2 time.Duration) *api_v2.PostS
StartTime: t1,
Duration: d1,
Tags: []model.KeyValue{
model.String(conventions.OtelStatusDescription, "Stale indices"),
model.Int64(conventions.OtelStatusCode, int64(ptrace.StatusCodeError)),
model.String(conventions.AttributeOTelStatusDescription, "Stale indices"),
model.Int64(conventions.AttributeOTelStatusCode, int64(ptrace.StatusCodeError)),
model.Bool("error", true),
},
References: []model.SpanRef{
Expand All @@ -325,8 +325,8 @@ func grpcFixture(t *testing.T, t1 time.Time, d1, d2 time.Duration) *api_v2.PostS
StartTime: t1.Add(d1),
Duration: d2,
Tags: []model.KeyValue{
model.String(conventions.OtelStatusDescription, "Frontend crash"),
model.Int64(conventions.OtelStatusCode, int64(ptrace.StatusCodeError)),
model.String(conventions.AttributeOTelStatusDescription, "Frontend crash"),
model.Int64(conventions.AttributeOTelStatusCode, int64(ptrace.StatusCodeError)),
model.Bool("error", true),
},
},
Expand Down

0 comments on commit 9efafed

Please sign in to comment.