VScode quick fix should not suggest removing @Autowired annotation from JUnit tests

[tigerinus]

Describe the bug

After a recent update of Spring Boot extension for VSCode, it starts to suggest removing @Autowired annotation from JUnit tests

However, after the annotation is removed, test is unable to get launched:

org.junit.jupiter.api.extension.ParameterResolutionException: No ParameterResolver registered for parameter [org.springframework.test.web.servlet.MockMvc mvc] in constructor [public com.newpathfly.flightsupplier.via.service.SearchServiceIT(org.springframework.test.web.servlet.MockMvc,java.lang.String)].
 at java.util.Optional.orElseGet([Optional.java:267](vscode-file://vscode-app/c:/Users/xiaoh/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/workbench/workbench.html))
 at java.util.ArrayList.forEach([ArrayList.java:1259](vscode-file://vscode-app/c:/Users/xiaoh/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/workbench/workbench.html))
 at java.util.ArrayList.forEach([ArrayList.java:1259](vscode-file://vscode-app/c:/Users/xiaoh/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/workbench/workbench.html))

To Reproduce

Build a simple Spring Boot test in an existing Spring Boot project:

@SpringBootTest
@AutoConfigureMockMvc
class WhateverIT {
    private final MockMvc _mvc;

    public WhateverIT (MockMvc mvc) {
        _mvc = mvc;
    }

    @Test
    void dummyTest() {
    }

Note that @Autowired does not exist.

Then try to launch the test from VSCode

[BoykoAlex]

Yes, agreed. Will get this fixed

[BoykoAlex]

Don't think i have better ideas than skipping the case of a class with @SpringBootTest annotation. Any objections?

[tigerinus]

Don't think i have better ideas than skipping the case of a class with @SpringBootTest annotation. Any objections?

What's the root cause of the issue?

Would you be able to skip the case of a class with any annotation that @BootstrapWith(SpringBootTestContextBootstrapper.class) in case people have their own annotation versus @SprintBootTest?

[BoykoAlex]

We've added removing @Autowired from the only constructor in class but conditions for this marker and quick fix are buggy.

Yes we can skip class annotated with @BootstrapWith(SpringBootTestContextBootstrapper.class) as well without any problems. Thanks for bringing this up

[BoykoAlex]

The fix is 382d0bb.
We'll be creating another release in a few days from now to include this fix. Once the RC is tested I'll mark it as fixed.

[BoykoAlex]

@tigerinus here is the RC that I've tried: https://s3.us-west-1.amazonaws.com/s3-test.spring.io/sts4/vscode-extensions/snapshots/vscode-spring-boot-1.36.0-RC.1.vsix
Seemed to work fine there.