Autowired field into constructor parameter #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoykoAlex
force-pushed
the
autowired-field
branch
from
2099447
to
08df793
Compare
|
@pway99 converted into a Visitor as discussed earlier |
pway99
reviewed
Jun 20, 2022
Comment on lines
46
to
48
| private String classFqName; | ||
|
|
||
| private String fieldName; |
There was a problem hiding this comment.
consider making these final
|
|
||
| @Override | ||
| public J visitClassDeclaration(ClassDeclaration classDecl, ExecutionContext p) { | ||
| if (classFqName.equals(classDecl.getType().getFullyQualifiedName())) { |
There was a problem hiding this comment.
I would suggest using TypeUtils here
Comment on lines
36
to
40
| get() = object : Recipe() { | ||
| override fun getDisplayName() : String { return "Convert autowired field" } | ||
| override fun getVisitor(): TreeVisitor<*, ExecutionContext> { | ||
| return AutowiredFieldIntoConstructorParameterVisitor("demo.A", "a") | ||
| } |
There was a problem hiding this comment.
this can be
override val recipe: Recipe
get() = toRecipe{AutowiredFieldIntoConstructorParameterVisitor("demo.A", "a")}
BoykoAlex
force-pushed
the
autowired-field
branch
from
08df793
to
7cd1c4b
Compare
|
@pway99 I've corrected the PR as suggested. Thanks very much for the review!-) |
|
Hi! Is there any recipe that uses this visitor? |
yeikel
pushed a commit
to yeikel/rewrite-spring
that referenced
this pull request
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes fq name of the class and field name and converts that field if it is
@Autowiredinto constructor parameter if there is a qualifying constructor.Does need some sort of
getApplicableTest()? Is it ok to be a recipe? Or you'd rather have it as a visitor? Feedback is welcomed.