Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid live hover connection attempt when deploying app to docker without actuator #716

Closed
martinlippert opened this issue Jan 19, 2022 · 1 comment
Assignees
Labels

Comments

@martinlippert
Copy link
Member

At the moment, when the user deploys a Spring Boot app to docker using the Spring Boot Dashboard, the live hover mechanism automatically kicks in and tries to connect to the app to visualize the live hovers. While this makes sense in general, this should not happen when the application doesn't have spring boot actuator in the classpath.

For apps that are running locally, this check is done automatically in the SpringProcessConnectorLocal based on the workspace project, but that information isn't around at this level for apps that are running in a docker container (and set to the language servers live hover mechanism via the remote processes mechanism).

I think this requires the necessary information to be passed via the remote apps mechanism to the live hovers mechanism of the language server in order to determine whether to auto-connect to the app or not.

@martinlippert martinlippert added this to the 4.13.1.RELEASE milestone Jan 19, 2022
@martinlippert martinlippert removed this from the 4.13.1.RELEASE milestone Feb 2, 2022
@kdvolder kdvolder self-assigned this Jul 22, 2022
@kdvolder
Copy link
Member

Fix was pushed.

@martinlippert martinlippert added this to the 4.15.2.RELEASE milestone Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants