-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Wild Web developer instead of Eclipse WTP #354
Comments
Update: Just learned from @mickaelistria that this migration was already done for the Eclipse packages. So you should also consider to switch. |
It's been done for the JavaScript package, not (yet) for the Enterprise Java package. |
I would love to replace large parts of WTP in the Spring Tools 4 for Eclipse distribution with the Wild Web Developer pieces (it is on my to do list for quite a while already), but I need to figure out all the dependencies among the various WTP features that we would still need. |
@martinlippert thanks, looking forward to it. |
Since there are no concrete plans to incorporate this into any STS 3.x distributions, I will move this over to the Spring Tools 4 issue tracker. |
I am pulling this from the upcoming 4.4 release, this requires a bit more thought and testing. Ripping out the right pieces of the WTP tools and replacing them with the Wild Web tooling is a major change and probably needs more work. One area that we need to investigate is the XML tooling that comes with the Wild Web package and whether we can use that as a full replacement of the existing tooling:
Other areas of work need to be identified and worked on. Nothing we can get done for the upcoming 4.4. release - unfortunately. |
One nice thing is that WWD has also support for *.scss files. |
Also using WWD should get rid of multiple UI freezes I get with the STS like the following: Stack Trace |
Confused non-polemic Eclipse user point of view: shouldn't be Eclipse teams responsibility first to clarify the relationships between WTP and Wild Web Developer first and perhaps integrate them better with one another? For instance, as a long time Eclipse & WTP user, it's not clear to me if and how WTP and WWD can coexist with each other on the same Eclipse installation, especially wrt HTML, XML, CSS and JS tools. And, assuming I am able to install just WWD editors for HTML, XML, CSS and JS, will JSF, JSP, WSDL editors from WTP still work? Is there some discussion about this? I tried to search on Google but just found https://www.eclipse.org/lists/wtp-dev/msg10917.html and https://bugs.eclipse.org/bugs/show_bug.cgi?id=544355, which however seem to be just one side of the story. What is WTP developers point of view on this? Perhaps this could also help STS developers to better identify how to proceed? |
Mauro, we are in process of adding wwd to the Java EE package and removing
(if possible) the old wtp editors. See for example
https://git.eclipse.org/r/157414
Mauro Molinari <[email protected]> schrieb am Do., 27. Feb. 2020,
12:28:
… Confused non-polemic Eclipse user point of view: shouldn't be Eclipse
teams responsibility first to clarify the relationships between WTP and
Wild Web Developer first and perhaps integrate them better with one
another? For instance, as a long time Eclipse & WTP user, it's not clear to
me if and how WTP and WWD can coexist with each other on the same Eclipse
installation, especially wrt HTML, XML, CSS and JS tools. And, assuming I
am able to install just WWD editors for HTML, XML, CSS and JS, will JSF,
JSP, WSDL editors from WTP still work?
Is there some discussion about this? I tried to search on Google but just
found https://www.eclipse.org/lists/wtp-dev/msg10917.html and
https://bugs.eclipse.org/bugs/show_bug.cgi?id=544355, which however seem
to be just one side of the story. What is WTP developers point of view on
this?
Perhaps this could also help STS developers to better identify how to
proceed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#354?email_source=notifications&email_token=AABCFBRAGJN7IABZW3PQZ6DRE6PURA5CNFSM4ISBRPW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENEAJNA#issuecomment-591922356>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCFBUYEXWQRIDLPE5LJZTRE6PURANCNFSM4ISBRPWQ>
.
|
Hi Lars, thanks to that link I found https://bugs.eclipse.org/bugs/show_bug.cgi?id=551408, which however is about just providing both WTP and WWD editors to the Eclipse IDE for JEE developers package for HTML, XML, CSS and JavaScript, with overlapping features, correct me if I'm wrong. I'm still perplexed on the whole picture, especially when you don't use an EPP package and you possibly install both WTP and WWD (on purpose or by chance). Having duplicate plugins for the same feature I think is quite confusing for end users. |
(comment in Pivotal Tracker added by Martin Lippert:) When moving forward with this, we need to think about integrating our XML tooling with the XML language server in Wild Web Developer. Some interesting references about that can be found in this email: |
(comment in Pivotal Tracker added by Martin Lippert:) Another source: eclipse-lemminx/lemminx#596 (comment) |
In order to push this forward, I went ahead and added Wild Web Developer to th Eclipse 4.17-based CI builds, which you can download from here: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html. However, the result is still not what I would like to see from the user experience point of view. Even though https://git.eclipse.org/r/157414 removed some standard WTP editors from the product (and I don't include those in the STS4 product either), they are being dragged into the product nevertheless by other features, like m2e-wtp (as far as I've seen). The Wild Web Developer extension seems to work fine, but as a user you need to explicitly choose to "Open With..." to open specific files (like HTML, XML or JavaScript) with the generic editor instead of the WTP ones. So coming back to your initial request to add the extension, @vogella, I am wondering what exactly you would expect here. We can try to walk the feature and plugin dependency chains and try to get rid of specific dependencies and feature inclusions for sure, but I am not sure people are willing to give up their traditional pom.xml editor with all those tabs and extra features (for example) in order to get rid of the WTP XML editor (which is included there). @vogella Do you have any additional thoughts on this? |
I think m2e-wtp should not drag in the outdated WTP editors. Please open a bug for m2e and cc @mickaelistria (and myself) to the bug. Mickael works on reducing the dependencies before. My hope for this change is that the language based editors are using by default. |
For myself... I am sure that I do not want to loose at least some of the features in the pom editor. Specifically the dependency related funtionality that lets you view and search the dependency tree. This is an extremely useful feature. Other than that the 'textual' component of the pom.xml editor... it isn't the greatest experience and probably won't be missed. (I do use it of course, but if its replaced by another 'xml-schema-aware' editor it would probably be just as good or probably better. |
Here is the related item at m2e: https://bugs.eclipse.org/bugs/show_bug.cgi?id=553183 |
And I filed an additional one to discuss dependencies around m2e-wtp: https://bugs.eclipse.org/bugs/show_bug.cgi?id=566077 |
Hi @martinlippert, I see this is closed now, does it mean next STS 4.8.0 will ship WWD instead of WTP then? |
Not exactly... ;-) The upcoming Spring Tools 4 for Eclipse release (4.8.0) will include WWD by default for the Eclipse 2020-09-based distribution as an experimental part of the distribution. Therefore I closed this ticket and marked it for the upcoming 4.8.0 release. Due to various dependencies across multiple bundles and features, we were not able to fully remove WTP UI tooling from the distribution. As a result, you will see a set of duplication across several features, including HTML and JavaScript editors, and a few more. You will be able to switch to the WWD editors, but due to the duplication they are not the default editors yet. This is all work-in-progress and we try to make progress on further reducing dependencies on WTP UI features across the board. Another piece that we haven't ported yet to WWD is the project-related XSD namespace resolution, that is also be to done for one of the upcoming releases. So we are making progress, but we aren't there yet. |
Does it mean that 4.8.0 will present issue #447 "out-of-the-box"? |
Not "out-of-the-box", since the default XML editor will still be the WTP one. But if you switch to the WWD-based generic editor to work on Spring XML config files, the problem will appear. |
That's not really true as Wild Web Developer plugs its analysis at document level, so it can show reports on other editors. |
@mickaelistria Thanks for the pointer, wasn't aware of that. The "problem" is not really a bug in LemMinx, but a special XSD namespace resolution mechanism that we need to plug into LemMinx (as we did in the past for WTP). So lets double check whether the issue actually occurs. If this happens, can users disable or switch the severity of specific validations in LemMinx? (as a workaround) |
Nope, they'd most likely need to disable the LemMinX LS as advised in the other bug. |
@martinlippert if you recall from bug #447, the problem was not about using the WWD XML editor in place of the WTP one, but rather that the WWD XML language server was "on" by default and this interfered with STS special XSD namespace resolution. The workaround was to disable the WWD XML language server. So perhaps you may evaluate to ship STS with WWD language servers disabled by default and perhaps document this known issue in some way... |
@mickaelistria Any concrete pointer which part of m2e you mean here? |
Never mind, I think I found the code... :-) |
Technically, you can as it's just a matter of setting preference
MavenLemminxExtension can be interesting if you want to consider it a lemminx extension, I'm not sure a lemminx extension allows to ignore some files though... By order of preference, I think you should investigate:
|
@mickaelistria Thanks a lot for the additional insights and ideas, much appreciated. I think the "correct" solution to this would be to implement a lemminx extension that registers a URIResolverExtension. But even that is not trivial to implement as an extension to lemminx for our case, since the URI resolution mechanism that we need is project-specific, so you need some sort of project context when resolving the namespace and look up things on the classpath of the specific project. Therefore a schema catalog doesn't really help. Since lemminx doesn't seem to have any project-specific information around (let aside the classpath information of a project), it might be necessary to implement some kind of language-server communication to get that information into the lemminx extension to do the resolving. I don't really have an idea for a short-term solution or workaround beyond disabling the XML language server. Given the fact that this issue appears only for very specific situations, I am reluctant to disable the entire XML language server by default for everybody. But to be honest, I am not very happy either way. |
The next step here will be to find a way to implement the project-specific resolver as an extension to the lemminx project. I will start to work on that once we have the 4.8.0 release out the door and follow up on the lemminx project for more help with that extension authoring and possible or necessary changes in lemminx. Looks like I will have to investigate this a bit... :-) @mickaelistria Thanks again for the feedback and ideas, much appreciated. Lets continue on the lemminx project with it. |
I still see issues with Angular templates in eclipse 2024! Can anyone let me know where to remove the old HTML package from Eclipse Java EE? Thanks |
The Spring Tools for Eclipse distributions do not ship with the old HTML tooling anymore. In case you are referring to the standard Eclipse JEE package, the question is probably a better for fit for https://github.com/eclipse-packaging/packages |
https://github.com/eclipse/wildwebdeveloper is currently developed by Red Hat with the intention to provide light-weight language server based support for JavaScript, JSon, etc.
I suggest you evaluate if this package can be used instead of Eclipse WTP.
The EPPs are also planning to do that https://bugs.eclipse.org/bugs/show_bug.cgi?id=544355
The text was updated successfully, but these errors were encountered: