Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code Extensions missing Cloud Foundry params options #330

Closed
mjnorman opened this issue Jul 22, 2019 · 5 comments
Closed

VS Code Extensions missing Cloud Foundry params options #330

mjnorman opened this issue Jul 22, 2019 · 5 comments
Milestone

Comments

@mjnorman
Copy link

mjnorman commented Jul 22, 2019

Hello all. For VSCODE extensions, It does not look like all of the appropriate options are available via intellisense, and errors occur for those not included. For example including vars results in an error.:

  - put: cloud-foundry-g1
    params:
      vars:
        MYVAR: myvalue
      manifest: manifest.yml

This looks like where it would need to be added, although my familiarity with VS Code Extensions is limited.

@kdvolder
Copy link
Member

Thanks for the report. Likely these are attributes that were added after we created the editor. We try to keep it up to date, but realistically we need people like yourself to tell us when something new got added that is ''missing' from our editor.

For example including vars ...

Is that the only missing attribute you are aware of? I am asking because your title suggest there are more than one. So if there are others that you are aware of, it would be helpful to list explicitly as well.

@mjnorman
Copy link
Author

Yes I didn't want to bloat the issue, but you're right I should be complete!

I see these as missing when comparing docs from original repo, https://github.com/concourse/cf-resource

Source attributes:

  • client_id: Optional. The client id used to authenticate.
  • client_secret: Optional. The client secret used to authenticate.
  • verbose: Optional. Invoke cf cli using CF_TRACE=true to print all API calls made to Cloud Foundry.

Param Attributes

  • vars: Optional. Map of variables to pass to manifest
  • vars_files: Optional. List of variables files to pass to manifest
  • docker_username: Optional. This is used as the username to authenticate against a protected docker registry.
  • docker_password: Optional. This should be the users password when authenticating against a protected docker registry.
  • show_app_log: Optional. Tails the app log during startup, useful to debug issues when using blue/green deploys together with the current_app_name option.
  • no_start: Optional. Deploys the app but does not start it. This parameter is ignored when current_app_name is specified.

@kdvolder
Copy link
Member

Thank you, that is very helpful :-)

kdvolder added a commit that referenced this issue Jul 23, 2019
... CF resource 'source' in Concourse Editor.

See: #330
kdvolder added a commit that referenced this issue Jul 23, 2019
... CF resource 'source' in Concourse Editor.

See: #330
kdvolder added a commit that referenced this issue Jul 23, 2019
... CF resource 'put' params in Concourse Editor.

Adding support for the following:

- vars
- vars_files
- docker_username
- docker_password
- show_app_log
- no_start

See: #330
@kdvolder
Copy link
Member

Should be all updated with support for all of these now. If you want to try you can download a snapshot build from this page: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html

@mjnorman
Copy link
Author

This seems to be working fine, thanks for the quick update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants