Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a Spring XML configuration file, the package names and class names do not appear accurately #1317

Closed
batobolg opened this issue Aug 8, 2024 · 2 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion theme: xml-support type: bug

Comments

@batobolg
Copy link

batobolg commented Aug 8, 2024

When editing a Spring XML configuration file, the package names and class names do not appear accurately.

To Reproduce
My test project is simple, I have just one package test.java and one Class TestMain.java
when I make a Spring XML configuration file, and edit it like below , it not show up my class name at the top

Sample
image

the error log is
image

@martinlippert martinlippert added theme: xml-support for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion and removed status: waiting-for-triage labels Aug 12, 2024
@martinlippert martinlippert added this to the 4.25.0.RELEASE milestone Aug 12, 2024
@martinlippert martinlippert self-assigned this Aug 12, 2024
@martinlippert
Copy link
Member

Looks like the auto completion proposals that show up while trying test.java. or somewhat weird and don't fit well. When you invoke auto-completion manually after typing test.java., the proposals are are a much better fit here. Let me investigate this so see what is going on here and how we could improve this.

martinlippert added a commit that referenced this issue Aug 30, 2024
… the list is incomplete or not + refined the way class and package proposals show up in XML config files
@martinlippert
Copy link
Member

I made some changes to the underlying mechanism that produces better results than before. It is still not optimal, for example it doesn't show up class proposals for types that are not public (whereas having a non-public class as bean is totally fine in Spring). But reworking that part requires us to change the way we identify the proposals altogether, so a lot more work.

@batobolg Feel free to give this improved version a try. The snapshot builds will be published here sometime soon: https://cdn.spring.io/spring-tools/snapshot/STS4/nightly-distributions.html

(make sure you grab a build that is older than 4.25.0.202408300825)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: code completion theme: xml-support type: bug
Projects
None yet
Development

No branches or pull requests

2 participants