Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis reads session once not twice during cleanup #2917

Closed
wants to merge 1 commit into from
Closed

Redis reads session once not twice during cleanup #2917

wants to merge 1 commit into from

Conversation

kinsersh
Copy link
Contributor

@kinsersh kinsersh commented Apr 8, 2024 •
edited
Loading

I noticed that the session gets read twice at

spring-session/spring-session-data-redis/src/main/java/org/springframework/session/data/redis/ReactiveRedisIndexedSessionRepository.java

Lines 441 to 442 in 4dc81ec

.flatMap((sessionId) -> getSession(sessionId, true))
.flatMap((session) -> this.deleteById(session.getId()).thenReturn(session))

This alters the code to only read it once.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 8, 2024
@marcusdacoregio marcusdacoregio added type: bug A general bug in: redis and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2024
@marcusdacoregio marcusdacoregio self-assigned this May 13, 2024
@marcusdacoregio marcusdacoregio added this to the 3.3.0 milestone May 13, 2024
@kinsersh kinsersh deleted the optimize-cleanup branch May 24, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: redis type: bug A general bug
Projects
Spring Security Team
Status: No status
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kinsersh @marcusdacoregio @spring-projects-issues