Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace expired msdn link with latest web archive copy #9050

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Replace expired msdn link with latest web archive copy #9050

merged 1 commit into from
Sep 28, 2020

Conversation

muRn
Copy link
Contributor

@muRn muRn commented Sep 25, 2020

Javadoc for org.springframework.security.config.annotation.web.configurers.HeadersConfigurer class contained MSDN blog link that expired in March, 2016 and is not usable since. I decided to replace it with latest possible web archive copy of that blog post (from February, 2016). I didn't create issue for such a minor change, hope it's OK.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 25, 2020
@muRn
Copy link
Contributor Author

muRn commented Sep 25, 2020

If I understand the build log correctly build failed because 1 of integration tests failed:

2020-09-25T18:06:47.3891611Z org.springframework.security.config.annotation.rsocket.RSocketMessageHandlerITests > retrieveFluxWhenDataFluxAndSecureThenDenied FAILED
2020-09-25T18:06:47.3894951Z     java.lang.AssertionError at RSocketMessageHandlerITests.java:168

I don't think changes in the PR could cause it. Please rerun build if possible

@jzheaux
Copy link
Contributor

jzheaux commented Sep 28, 2020

Thanks, @muRn, for the PR! In preparation for merging, will you please squash your commits?

Initial link expired in March, 2016. Latest copy found in web archive is from February, 2016
@muRn
Copy link
Contributor Author

muRn commented Sep 28, 2020

Squashed my commits & force pushed. Is it OK now?

@jzheaux jzheaux merged commit dc5f244 into spring-projects:master Sep 28, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Sep 28, 2020

Thanks, @muRn, for the PR! It's now merged into master.

@jzheaux jzheaux self-assigned this Sep 28, 2020
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 28, 2020
@jzheaux jzheaux added this to the 5.4.1 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants