Replace Tomcat6 URL for SSL Guide to Tomcat 10 #9034
Conversation
|
@b12f10w Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@b12f10w Thank you for signing the Contributor License Agreement! |
| @@ -15,7 +15,7 @@ It maps the certificate to an application user and loads that user's set of gran | |||
|
|
|||
| You should be familiar with using certificates and setting up client authentication for your servlet container before attempting to use it with Spring Security. | |||
| Most of the work is in creating and installing suitable certificates and keys. | |||
| For example, if you're using Tomcat then read the instructions here https://tomcat.apache.org/tomcat-6.0-doc/ssl-howto.html[https://tomcat.apache.org/tomcat-6.0-doc/ssl-howto.html]. | |||
| For example, if you're using Tomcat then read the instructions here https://tomcat.apache.org/tomcat-10.0-doc/ssl-howto.html[https://tomcat.apache.org/tomcat-10.0-doc/ssl-howto.html]. | |||
There was a problem hiding this comment.
Since Spring Boot requires a minimum of Tomcat 9, I think it's best to point to the Tomcat 9. Would you please update this accordingly?
There was a problem hiding this comment.
I understand your comments. I will change this point.
Thank you.
There was a problem hiding this comment.
I completed fix my pull request as your comment.
Thanks.
.gitignore
Outdated
| @@ -28,3 +28,4 @@ s101plugin.state | |||
|
|
|||
| !.idea/checkstyle-idea.xml | |||
| !.idea/externalDependencies.xml | |||
| *.xsd | |||
There was a problem hiding this comment.
Please leave this out of this PR. I'm thinking that we don't want to ignore .xsd files since we've got some in the repo, but if you feel like this change is necessary, please open a separate ticket.
There was a problem hiding this comment.
I understand your comments.
I will follow your comments.
Thank you.
There was a problem hiding this comment.
I completed cancel my commit as your comment.
Thanks.
jzheaux
added
in: docs
b12f10w
force-pushed
the
master
branch
2 times, most recently
from
f5e9c53 to
d9b1615
Compare
|
Thanks, @b12f10w! This is now merged into |
I suggest SSL setup guide link from tomcat6 to tomcat10.
Tomcat 6 document for ssl (SSL is changed by SSL/TLS in tomcat 7,8,9,10 server document) is old.
So, I create pull request.
Also, I think it would better add xsd format in .ignore, So I suggest this file.
Regards.