-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JwtDecoders and ReactiveJwtDecoders with customizable RestTemplate and WebClient #8690
JwtDecoders and ReactiveJwtDecoders with customizable RestTemplate and WebClient #8690
Conversation
610517d
to
a50017c
Compare
@bedla There are still too many changes in this PR. As mentioned in this comment, we need to align on strategy for configuring the http clients so I'm expecting that to be demonstrated with one use case only:
After we align on approach, then the rest can be implemented. I'm going to close #8624 and keep this one open for now. |
@jgrandja From my understanding of code base there are two seperate areas where |
@bedla I've submitted #8732, which addresses HTTP client configuration for OAuth 2.0 Client. The team is currently discussing on what approach we should take for HTTP client configuration. After we decide on approach for OAuth 2.0 Client, we can implement a similar pattern in the JOSE stack. For now, please hold off on any updates. Having said that, I did manage to do a quick review and I will say there are quite a few |
@bedla Thank you for your time on this PR. However, we won't be able to accept these changes. There has been a lot of investigation work on figuring out how to allow an application to provide a custom |
Hi,
I have created PR that makes
JwtDecoders
andReactiveJwtDecoders
customizable with passedRestTemplate
orWebClient
. Changes are around all related classes that use this classes. This PR is related to my second PR #8624 that has to be changed in size.I am open any changes you propose.
Thx,
Ivos