Allow setting realm for Http Basic #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurpathak
force-pushed
the
gh-6270-fix
branch
3 times, most recently
from
769d136 to
71f73c0
Compare
rwinch
requested changes
Dec 14, 2018
| * @since 5.2.0 | ||
| * @author Ankur Pathak | ||
| */ | ||
| public HttpBasicSpec realmName(String realmName){ |
There was a problem hiding this comment.
I think that rather than specifying realmName we should allow injection of the entryPoint instead. This gives the user more flexibility and we don't need this additional logic which does an instance of check.
There was a problem hiding this comment.
I do agree, allowing setting entryPoint will give user more flexibility. So method to set realmName
removed in its favour. The new method authenticationEntryPoint added in its place.
rwinch
added
the
status: waiting-for-feedback
ankurpathak
force-pushed
the
gh-6270-fix
branch
from
71f73c0 to
0b66c7a
Compare
1. Added method authenticationEntryPoint in ServerHttpSecurity to allow setting authenticationEntryPoint. 2. Added test in ServerHttpSecurityTests to check if if specified realm name set by authenticationEntryPoint is returned Fixes: spring-projectsgh-6270
ankurpathak
force-pushed
the
gh-6270-fix
branch
from
0b66c7a to
e210b93
Compare
rwinch
added
in: config
rwinch
approved these changes
Dec 17, 2018
|
Thanks for the PR @ankurpathak! This is now merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specifying realm name.
specified realm name is returned.
Pull request for issue: #6270