Provide Runtime Hints for Beans used in Pre/PostAuthorize Expressions #15794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
in: core
marcusdacoregio
force-pushed
the
gh-14652-hints
branch
2 times, most recently
from
08ce365 to
560d4a6
Compare
jzheaux
requested changes
Sep 12, 2024
There was a problem hiding this comment.
So exciting, @marcusdacoregio. I've left a piece of feedback inline.
Also, it's interesting that this class requires searching the object graph recursively as well. I wonder if there is a better abstraction that could work for the handful of use cases that we have.
For example, traversing hierarchies often lends itself to Visitor pattern and following such may unify these currently disparate classes.
There are other things in common about the use cases as well:
- There will always be unreachable objects, so there needs to be a way to provide those manually
- Spring Data-specific awareness would increase reachability
For now, I think this is a fine start, but perhaps a ticket to explore an improved abstraction for these cross-cutting concerns would be beneficial.
...java/org/springframework/security/aot/hint/PrePostAuthorizeExpressionBeanHintsRegistrar.java
Show resolved
Hide resolved
marcusdacoregio
force-pushed
the
gh-14652-hints
branch
from
4ef604e to
d6a1122
Compare
jzheaux
approved these changes
Sep 12, 2024
marcusdacoregio
force-pushed
the
gh-14652-hints
branch
from
d6a1122 to
187a3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-14652