Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation expression template processing should not fail on Class parameter types #15711

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Annotation expression template processing should not fail on Class parameter types #15711

merged 1 commit into from
Sep 4, 2024

Conversation

kse-music
Copy link
Contributor

@kse-music kse-music commented Aug 30, 2024 •
edited
Loading

relate to gh-15721

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 30, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Sep 3, 2024

Thanks, @kse-music! I think this is just an oversight. All legal annotation parameter types should work by default.

Can you rebase this PR to 6.3.x and then use a local ConversionService instance that includes a ClassToString converter by default?

@jzheaux jzheaux self-assigned this Sep 3, 2024
@jzheaux jzheaux added in: core An issue in spring-security-core type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 3, 2024
@jzheaux jzheaux added this to the 6.3.4 milestone Sep 3, 2024
@kse-music kse-music changed the base branch from main to 6.3.x September 4, 2024 02:13
@kse-music kse-music changed the title Add ignoreUnconverted property for AnnotationTemplateExpressionDefaults Use AuthorizationAnnotationPropertyConversionService Sep 4, 2024
@kse-music
Copy link
Contributor Author

@jzheaux I have added a local conversion service

jzheaux
jzheaux requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kse-music! I've left my feedback inline.

...ramework/security/authorization/method/AuthorizationAnnotationPropertyConversionService.java Outdated Show resolved Hide resolved
.../java/org/springframework/security/config/annotation/web/AbstractRequestMatcherRegistry.java Outdated Show resolved Hide resolved
...security/config/annotation/method/configuration/PrePostMethodSecurityConfigurationTests.java Show resolved Hide resolved
@kse-music kse-music changed the title Use AuthorizationAnnotationPropertyConversionService Use Custom AuthorizationAnnotationProperty ConversionService Sep 4, 2024
@kse-music
Copy link
Contributor Author

@jzheaux All feedback has been completed

@jzheaux jzheaux changed the title Use Custom AuthorizationAnnotationProperty ConversionService Annotation expression template processing should not fail on Class parameter types Sep 4, 2024
@jzheaux jzheaux merged commit 5c20505 into spring-projects:6.3.x Sep 4, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Sep 4, 2024

Thanks, @kse-music! This is now merged into 6.3.x and main

@kse-music kse-music deleted the eh-tpl branch September 28, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: bug A general bug
Projects
None yet
Milestone
6.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kse-music @jzheaux @spring-projects-issues