Updated Documentation about Kotlin Coroutine Support #14646 #14797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4646 Update Documentation about Kotlin Coroutine Support spring-projects#14646
|
@Chillthrower Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Chillthrower Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sjohnr
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Hi @Chillthrower thanks for the contribution! See one comment below and let me know if you agree.
In addition, there is a reference to the pending Kotlin coroutines support earlier in this page. I think the this should change from:
- Supports reactive return types. Note that we are waiting on additional coroutine support from the Spring Framework before adding coroutine support.
to:
- Supports reactive return types including Kotlin coroutines.
Would you be able to make these changes?
sjohnr
added
in: docs
…14646 spring-projects#14797 Remove warning/info block and update content as per maintainer's request
|
@Chillthrower did you see my request above for updating another section of this page? I don't see that update. |
…14646 spring-projects#14797 removed the paragraph and added "Supports reactive return types including Kotlin coroutines."
|
Thanks @Chillthrower! This is now merged as b5c9ba6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Documentation about Kotlin Coroutine Support #14646