Fix inaccurate information about permitting the FORWARD dispatcher in Kotlin #13729
Conversation
|
@username1103 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@username1103 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
CONTRIBUTING.adoc
Outdated
| @@ -31,7 +31,7 @@ If you have a question, check Stack Overflow using | |||
| https://stackoverflow.com/questions/tagged/spring-security+or+spring-ldap+or+spring-authorization-server+or+spring-session?tab=Newest[this list of tags]. | |||
| Find an existing discussion, or start a new one if necessary. | |||
|
|
|||
| If you believe there is an issue, search through https://github.com/spring-projects/spring-security/issues[existing issues] trying a few different ways to find discussions, past or current, that are related to the issue. | |||
| If you believe there is an issue, search through https://github.com/spring-projects/spring-security/issues[existing issues] trying a few different ways to find discussions, past or current, that are related to the issue. | |||
There was a problem hiding this comment.
Let's keep the PR focused on focusing on that single part of the documentation. If needed you can open another PR that fix the typos.
CONTRIBUTING.adoc
Outdated
| @@ -79,7 +79,7 @@ See https://github.com/spring-projects/spring-security/tree/main#building-from-s | |||
|
|
|||
| The wiki pages https://github.com/spring-projects/spring-framework/wiki/Code-Style[Code Style] and https://github.com/spring-projects/spring-framework/wiki/IntelliJ-IDEA-Editor-Settings[IntelliJ IDEA Editor Settings] define the source file coding standards we use along with some IDEA editor settings we customize. | |||
|
|
|||
| To format the code as well as check the style, run `./gradle format check`. | |||
| To format the code as well as check the style, run `./gradlew format check`. | |||
There was a problem hiding this comment.
Let's keep the PR focused on fixing that single part of the documentation. If needed you can open another PR that fixes the typos.
| * @param access the [AuthorizationManager] to secure the matching request | ||
| * (i.e. created via hasAuthority("ROLE_USER")) | ||
| */ | ||
| fun authorize(dispatcherType: DispatcherType, |
There was a problem hiding this comment.
We should not add this new method since there is the option to do authorize(DispatcherTypeRequestMatcher(DispatcherType.FORWARD), permitAll) and the PR should only fix the documentation issue
marcusdacoregio
added
in: docs
|
@marcusdacoregio In light of your feedback, I have removed the typo corrections and new method in this pr. I have kept only the commit that pertains to modifying the document I appreciate your input. Thank you. |
|
Thanks, @username1103, this is now merged into |
closes gh-13728
This PR includes both of the methods suggested in the issue. Therefore, once one of them is adopted, the commits related to the other changes will be removed. Please provide your opinion on which method would be preferable.