-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify configuration of OAuth2 Client component model #13587
Simplify configuration of OAuth2 Client component model #13587
Conversation
4bc7a14
to
995b1eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @sjohnr ! This looks great! Please see review comments for a couple of very minor changes.
...in/java/org/springframework/security/config/http/OAuth2AuthorizedClientManagerRegistrar.java
Show resolved
Hide resolved
...va/org/springframework/security/config/http/OAuth2AuthorizedClientManagerRegistrarTests.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/security/config/http/OAuth2AuthorizedClientManagerRegistrarTests.java
Outdated
Show resolved
Hide resolved
...ity/config/annotation/web/configuration/OAuth2AuthorizedClientManagerConfigurationTests.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/security/config/http/OAuth2AuthorizedClientManagerRegistrarTests.java
Outdated
Show resolved
Hide resolved
995b1eb
to
dbf9b50
Compare
Still in progress? |
@rishiraj88 this is now merged. I'll be working on reference documentation next to demonstrate how the feature works. Are you interested in trying it out on a SNAPSHOT? |
This PR is the most recent iteration of design work for simplifying the configuration of the OAuth2 Client component model. The following list documents progress:
Issue gh-11783