Dependencies are resolved from appropriate repositories #13582
Conversation
This change applies repository content filtering to configured repositories, reducing the time spent during dependency resolution. This fixes an issue where requests for 'org.opensaml', 'net.shibboleth.utilities' and 'net.minidev' dependencies were being made in the Spring releases repositories, resulting in many failed requests during dependency resolution and increased resolution times.
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
type: enhancement
|
Thanks for the PR @erichaagdev I've merged this into 5.8.x via 30bc263 and then merged into 6.0.x 6.1.x and main (6.2.0-M2) |
This makes the include more robust Issue gh-13582
Use includeGroupByRegex This makes the include more robust Issue gh-13582
Use includeGroupByRegex This makes the include more robust Issue gh-13582
Use includeGroupByRegex This makes the include more robust Issue gh-13582
There was a problem hiding this comment.
Thanks, @erichaagdev, this is really exciting. I've left some feedback inline.
| @@ -1,6 +1,7 @@ | |||
| plugins { | |||
| id 'org.antora' version '1.0.0' | |||
| id 'io.spring.antora.generate-antora-yml' version '0.0.1' | |||
| id 'io.spring.convention.repository' | |||
There was a problem hiding this comment.
Why is this part of this commit? Is it necessary to prevent the unnecessary checks?
There was a problem hiding this comment.
Yes. Some of the failed calls were caused by resolving dependencies for this project. By using the repository conventions plugin we make sure this project uses the same resolution rules as the rest of the build. You will notice I also removed the now redundant repository declarations previously present at the end of this build file (lines 64-70).
| @@ -34,6 +34,14 @@ class RepositoryConventionPlugin implements Plugin<Project> { | |||
| if (forceMavenRepositories?.contains('local')) { | |||
| mavenLocal() | |||
| } | |||
| maven { | |||
There was a problem hiding this comment.
While minor, could this remain in its original place in the file? If so, it's a little easier to follow the Git history if only the edits needed to affect the change are what gets committed.
There was a problem hiding this comment.
This move was intentional. Gradle will resolve dependencies from repositories in the order they are declared. This move ensures the shibboleth dependencies are not attempted to be resolved from any other repository. For example, if this was moved to be after mavenCentral(), then Gradle will attempt to resolve the shibboleth dependencies from Maven Central even though they are not available there. Then, the content inclusion (includeGroup) ensures no other dependencies are attempted to be resolved from the shibboleth repository.
This change applies repository content filtering to configured repositories, reducing time spent during dependency resolution.
Previously, attempts would be made to resolve dependencies for
org.opensaml.*,net.shibboleth.utilities.*, andnet.minidev.*from the Spring releases repository, resulting in numerous failed requests during dependency resolution and prolonged resolution times.This was particularly noticeable during IDE sync times. With these changes, my IDE sync time is ~3s whereas previously it was consistently above 40s.