Gh 12472 #12638
Closed
Gh 12472 #12638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Feb 15, 2023
There was a problem hiding this comment.
Thanks, @dkodippily, this looks great. I've left some feedback inline.
Because this is targeting 5.8.x, will you please rebase against that branch? Also, I think we are ready at this point for you to squash your commits to one.
...aml2/provider/service/web/authentication/logout/HttpSessionLogoutRequestRepositoryTests.java
Outdated
Show resolved
Hide resolved
...aml2/provider/service/web/authentication/logout/HttpSessionLogoutRequestRepositoryTests.java
Outdated
Show resolved
Hide resolved
jzheaux
added
status: duplicate
|
Hi @jzheaux , I have added the fix to 5.8.x and we'll create a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked the
encoderinstance variable ofSaml2LogoutRequest.javatransient, further added unit testes toHttpSessionLogoutRequestRepositoryTests.javato confirm the serialization/deserialization ofSaml2LogoutRequest.