Revisit Session Management docs #12601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
status: duplicate
jzheaux
requested changes
Feb 6, 2023
|
|
||
|
|
||
| include::partial$servlet/architecture/security-context-explicit.adoc[] | ||
|
|
There was a problem hiding this comment.
I feel like this needs a flow chart that shows when each of these components is triggered on:
- an already-authenticated request
- an authentication request
The chart would include and then link to the sections relevant to each square in the chart.
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
|
Thanks, @jzheaux, I've addressed your suggestions and updated the PR. I also reverted this commit based on @rwinch feedback. |
jzheaux
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Such a huge improvement, @marcusdacoregio. Thanks for your efforts.
marcusdacoregio
force-pushed
the
gh-12519
branch
from
59962a8 to
ea9252c
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-12519