Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty authorities by default to easily build a user #12555

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add empty authorities by default to easily build a user #12555

merged 1 commit into from
Jan 30, 2023

Conversation

stillya
Copy link
Contributor

@stillya stillya commented Jan 18, 2023 •
edited by sjohnr
Loading

Issue - gh-12533

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 18, 2023
@sjohnr sjohnr self-assigned this Jan 20, 2023
@sjohnr sjohnr added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 20, 2023
@sjohnr
Copy link
Member

sjohnr commented Jan 23, 2023

@stillya thanks for the PR!

Can you also please add tests for the two new cases introduced here:

  • Building a user with no authorities
  • Expecting IllegalArgumentException when giving null authorities

@stillya
Copy link
Contributor Author

stillya commented Jan 23, 2023

@sjohnr added tests and new asserts based on some test cases

@stillya
Copy link
Contributor Author

stillya commented Jan 25, 2023

noticed that action failed and fixed code style in test, now it have to be fine

@sjohnr
Copy link
Member

sjohnr commented Jan 26, 2023 •
edited
Loading

@stillya would you be able to squash your commits into a single commit, with a short message such as:

Add empty authorities by default

Closes gh-12533

Note: We won't bother updating the copyright year of the edited files because it has the old copyright notice.

@stillya stillya force-pushed the gh-12533-default-authorities branch from 5074990 to 57053a8 Compare January 27, 2023 04:58
@stillya
Copy link
Contributor Author

stillya commented Jan 27, 2023

Done.

@sjohnr sjohnr added this to the 6.1.0-M2 milestone Jan 30, 2023
@sjohnr sjohnr linked an issue Jan 30, 2023 that may be closed by this pull request
Allow UserBuilder to easily build a user without any authorities #12533
Closed
@sjohnr sjohnr merged commit 3229bfa into spring-projects:main Jan 30, 2023
@sjohnr
Copy link
Member

sjohnr commented Jan 30, 2023

Thanks @stillya!

@jzheaux jzheaux mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M2
Development

Successfully merging this pull request may close these issues.

Allow UserBuilder to easily build a user without any authorities
3 participants
@stillya @sjohnr @spring-projects-issues