Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds hints for Authentication manager #12366

Closed
wants to merge 1 commit into from
Closed

Adds hints for Authentication manager #12366

wants to merge 1 commit into from

Conversation

nkonev
Copy link
Contributor

@nkonev nkonev commented Dec 11, 2022

Fixes spring-projects/spring-framework#29599 (As a community guy I cannot move issue from the Framework to here)

@marcusdacoregio I saw you added some hints ef879aa, so I think I can ask you to review.

@nkonev nkonev changed the title Adds hitts for Authentication manager Adds hints for Authentication manager Dec 11, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 11, 2022
@nkonev nkonev force-pushed the add-hints-for-authentication-manager branch 2 times, most recently from 3ab85c9 to 520d62d Compare December 11, 2022 18:27
@nkonev nkonev force-pushed the add-hints-for-authentication-manager branch from 520d62d to 07f2f0b Compare December 11, 2022 18:55
nkonev
nkonev commented Dec 11, 2022
View reviewed changes
core/src/main/java/org/springframework/security/aot/hint/CoreSecurityRuntimeHints.java
@@ -19,14 +19,18 @@
import java.util.List;
import java.util.stream.Stream;

import org.springframework.aop.SpringProxy;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdeleuze Should we move SpringProxy, Advised and DecoratingProxy to the Spring Framework ? They can be useful for other

@marcusdacoregio marcusdacoregio self-assigned this Dec 12, 2022
@marcusdacoregio marcusdacoregio added in: core An issue in spring-security-core type: enhancement A general enhancement type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Dec 12, 2022
@marcusdacoregio marcusdacoregio added this to the 6.0.1 milestone Dec 12, 2022
@marcusdacoregio marcusdacoregio mentioned this pull request Dec 12, 2022
Closed
@marcusdacoregio
Copy link
Contributor

Hi @nkonev, thanks for the contribution.

You can go ahead and close that ticket in Spring Framework.

About the PR, I don't think we want to solve it this way. Instead, a delegate that delays the initialization of the bean would probably work in this case. I created #12367 for that

@nkonev
Copy link
Contributor Author

nkonev commented Dec 12, 2022 •
edited
Loading

Ok, I suspected that it isn't a simple fix :)
Closing in favor of #12367

@nkonev nkonev closed this Dec 12, 2022
@marcusdacoregio marcusdacoregio removed this from the 6.0.1 milestone Dec 12, 2022
@marcusdacoregio marcusdacoregio added the status: declined A suggestion or change that we don't feel we should currently apply label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkonev @marcusdacoregio @spring-projects-issues