Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix securityMatchers code sample #12301

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

beckermarc
Copy link
Contributor

http.securityMatcher(antMatcher("/api/**"), antMatcher("/app/**")) is not possible at the moment. There is no public HttpSecurity securityMatcher(RequestMatcher... requestMatcher) method only a public HttpSecurity securityMatcher(RequestMatcher requestMatcher) method (no varargs) is available. The correct alternative is http.securityMatchers().requestMatchers(antMatcher("/api/**"), antMatcher("/app/**"))

Fixes gh-12296

Copy link
Contributor

@marcusdacoregio marcusdacoregio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beckermarc, I left one feedback inline.

docs/modules/ROOT/pages/migration/servlet/config.adoc Outdated Show resolved Hide resolved
@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: docs An issue in Documentation or samples type: bug A general bug labels Nov 25, 2022
@marcusdacoregio marcusdacoregio self-assigned this Nov 25, 2022
@marcusdacoregio marcusdacoregio removed the status: waiting-for-triage An issue we've not yet triaged label Nov 25, 2022
@marcusdacoregio marcusdacoregio added this to the 5.8.1 milestone Nov 25, 2022
@marcusdacoregio
Copy link
Contributor

Thank you very much @beckermarc, as a preparation to merge, can you squash the commits into one and change the description to:

Fix securityMatchers code sample

Closes gh-12296

@marcusdacoregio marcusdacoregio merged commit 50da5b6 into spring-projects:5.8.x Nov 25, 2022
@marcusdacoregio
Copy link
Contributor

Thank you @beckermarc, this is now merged into 5.8.x

@beckermarc beckermarc deleted the patch-1 branch November 25, 2022 13:19
@beckermarc
Copy link
Contributor Author

Thanks @marcusdacoregio 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants