Replace deprecated set-state set-output GitHub Action's commands #12289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
kirklin
force-pushed
the
5.6.x
branch
3 times, most recently
from
34830fa to
fe4e9fb
Compare
kirklin
changed the title
marcusdacoregio
added
in: build
marcusdacoregio
suggested changes
Nov 25, 2022
There was a problem hiding this comment.
Thanks, @kirklin, I've left my feedback inline.
Also, can you please squash your commits into one?
| - name: Set up gradle | ||
| uses: spring-io/spring-gradle-build-action@v1 | ||
| uses: kirklin/spring-gradle-build-action@v1 |
There was a problem hiding this comment.
I don't think we want to use an action that is outside the Spring control, instead of doing this, we should open an issue in https://github.com/spring-io/spring-gradle-build-action in order to get a new version released with the deprecations replaced.
Please, let's keep spring-io/spring-gradle-build-action@v1 for now.
There was a problem hiding this comment.
ok!I will sync the update to spring-io/spring-gradle-build-action@v1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The save-state, set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Closes gh-12032