Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpSecurityDsl should support apply method #11771

Closed
wants to merge 4 commits into from
Closed

HttpSecurityDsl should support apply method #11771

wants to merge 4 commits into from

Conversation

hanrw
Copy link
Contributor

@hanrw hanrw commented Aug 31, 2022

Fix gh-11754

@pivotal-cla
Copy link

@hanrw Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@hanrw Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 31, 2022
sjohnr
sjohnr requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hanrw! As mentioned, I'll probably hold off on merging for a bit. See note below for a suggested change to the javadoc.

config/src/main/kotlin/org/springframework/security/config/annotation/web/HttpSecurityDsl.kt Outdated Show resolved Hide resolved
@sjohnr sjohnr self-assigned this Sep 6, 2022
@sjohnr sjohnr added in: config An issue in spring-security-config type: enhancement A general enhancement status: duplicate A duplicate of another issue labels Sep 6, 2022
@sjohnr sjohnr changed the title #11754 - HttpSecurityDsl should support apply method HttpSecurityDsl should support apply method Sep 6, 2022
@hanrw hanrw requested a review from sjohnr September 7, 2022 01:30
@sjohnr sjohnr removed the status: waiting-for-triage An issue we've not yet triaged label Sep 9, 2022
sjohnr
sjohnr reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hanrw! I'm circling back to this PR and while looking at this again, I had another thought. See below.

config/src/main/kotlin/org/springframework/security/config/annotation/web/HttpSecurityDsl.kt Outdated Show resolved Hide resolved
@hanrw hanrw requested a review from sjohnr September 14, 2022 13:01
@sjohnr
Copy link
Member

sjohnr commented Sep 14, 2022

Merged into 5.8.x and main as 45bbd86.

@sjohnr sjohnr closed this Sep 14, 2022
@sjohnr sjohnr added this to the 5.8.0-M3 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjohnr sjohnr Awaiting requested review from sjohnr

Assignees

@sjohnr sjohnr

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.8.0-M3
Development

Successfully merging this pull request may close these issues.

HttpSecurityDsl should support apply method
4 participants
@hanrw @pivotal-cla @sjohnr @spring-projects-issues