Remove Configuration meta-annotation from Enable* annotations #11653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, Spring Security's @enable* annotations were meta-annotated with @configuration. While convenient, this is not consistent with the rest of the Spring projects and most notably Spring Framework's @enable annotations. Additionally, the introduction of support for @configuration(proxyBeanMethods=false) in Spring Framework provides a compelling reason to remove @configuration meta-annotation from Spring Security's @enable annotations and allow users to opt into their preferred configuration mode. Closes spring-projectsgh-6613 Signed-off-by: Joshua Sattler <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: config
vpavic
added a commit
to vpavic/spring-session
that referenced
this pull request
Aug 17, 2022
As of spring-projects/spring-security#11653, Spring Security's [at]Enable*Security annotations are not meta annotated with [at]Configuration which breaks some of our tests. This commit adds missing [at]Configuration annotations where needed. Closes spring-projectsgh-2118
rwinch
pushed a commit
to spring-projects/spring-session
that referenced
this pull request
Aug 19, 2022
As of spring-projects/spring-security#11653, Spring Security's [at]Enable*Security annotations are not meta annotated with [at]Configuration which breaks some of our tests. This commit adds missing [at]Configuration annotations where needed. Closes gh-2118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, Spring Security's @enable* annotations were meta-annotated with @configuration.
While convenient, this is not consistent with the rest of the Spring projects and most notably
Spring Framework's @enable annotations. Additionally, the introduction of support for
@configuration(proxyBeanMethods=false) in Spring Framework provides a compelling reason to
remove @configuration meta-annotation from Spring Security's @enable annotations and allow
users to opt into their preferred configuration mode.
Closes gh-6613
Signed-off-by: Joshua Sattler [email protected]