Allow customization of redirect strategy #11387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
requested changes
Jun 27, 2022
There was a problem hiding this comment.
Thank you for the PR @igorbolic
This looks like it will work for reactive support, but we need to ensure that we have consistency with the servlet support as well.
Can you please:
- Add Support for OAuth2AuthorizationRequestRedirectFilter
- Ensure to add Java Configuration Support
- Ensure to add XML configuration support
@rwinch I've pushed the requested changes. Still, there are tests (unrelated to this PR) that are failing, but I've created PR #11462 to address them. I can rebase on top of changes in PR #11462 if/once they are merged to the main branch, just so that all tests pass in green with this PR. |
igorbolic
force-pushed
the
gh-11373
branch
2 times, most recently
from
54f034c to
feb47b2
Compare
The default redirect strategy will provide authorization redirect URI within HTTP 302 response Location header. Allowing the configuration of custom redirect strategy will provide an option for the clients to obtain the authorization URI from e.g. HTTP response body as JSON payload, without a need to handle automatic redirection initiated by the HTTP Location header. Closes spring-projectsgh-11373
rwinch
added
in: oauth2
|
Thank you for the PR @igorbolic! This has been merged into 5.8.x via efaee4e and main via 2e66b9f |
rwinch
reviewed
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default redirect strategy will provide authorization redirect
URI within HTTP 302 response Location header.
Allowing the configuration of custom redirect strategy will provide
an option for the clients to obtain the authorization URI from e.g.
HTTP response body as JSON payload, without a need to handle
automatic redirection initiated by the HTTP Location header.
Closes gh-11373