Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Base64 encoder with no CRLF in output for SAML 2.0 messages #11270

Merged
merged 1 commit into from
May 25, 2022

Conversation

junytse
Copy link
Contributor

@junytse junytse commented May 21, 2022

Saml2 message BASE64-encode results will not have line wrapped.

gh-11262

@jzheaux
Copy link
Contributor

jzheaux commented May 23, 2022

Thanks for the PR, @junytse. Will you please do me a favor and format your commit to include the issue that is being closed?

Like so:

Use Base64 encoder with no CRLF in output for SAML 2.0 messages

Closes gh-11262

This makes it easier to track changes in the future.

@jzheaux jzheaux self-assigned this May 23, 2022
@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels May 23, 2022
@jzheaux jzheaux added this to the 5.8.0-M1 milestone May 23, 2022
@junytse
Copy link
Contributor Author

junytse commented May 24, 2022

Thanks for the PR, @junytse. Will you please do me a favor and format your commit to include the issue that is being closed?

Like so:

Use Base64 encoder with no CRLF in output for SAML 2.0 messages

Closes gh-11262

This makes it easier to track changes in the future.

Updated.

@jzheaux jzheaux changed the base branch from main to 5.8.x May 25, 2022 17:41
@jzheaux jzheaux changed the base branch from 5.8.x to main May 25, 2022 17:41
@jzheaux jzheaux merged commit f2d6ead into spring-projects:main May 25, 2022
@junytse junytse deleted the gh-11262 branch May 26, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants