Change HashSet to LinkedHashSet for RelyingPartyRegistration credentials #10912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…credentials to preserve order of insertion.
|
Would love to have this simple fix back ported to maintenance branches too. Thank you! |
This was referenced Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the collections type in the RelyingPartyRegistration.Builder to
LinkedHashSetfromHashSetRelyingPartyRegistration constructor converts the credentials (
credentials,decryptionX509Credentials,signingX509Credentials) to unmodifiable, orderedLinkedListobjects.There is a chance, possibly minuscule but not non existent, that the Builder collections which uses HashSet/HashMap underneath may return a different order for these credentials. This may lead to very difficult debugging steps when a certain key (the first in the list) is expected to have been used for signing but wasn't.