Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHubReleasePlugin with createGitHubRelease task #10483

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Add GitHubReleasePlugin with createGitHubRelease task #10483

merged 2 commits into from
Dec 22, 2021

Conversation

sjohnr
Copy link
Member

@sjohnr sjohnr commented Nov 10, 2021

Closes gh-10457

@sjohnr sjohnr added status: duplicate A duplicate of another issue in: build An issue in the build type: task A general task labels Nov 10, 2021
@sjohnr sjohnr added this to the 5.7.x milestone Nov 10, 2021
@sjohnr sjohnr requested a review from eleftherias November 10, 2021 23:54
@sjohnr sjohnr self-assigned this Nov 10, 2021
eleftherias
eleftherias reviewed Nov 15, 2021
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sjohnr! I have left some suggestions inline.

buildSrc/src/main/java/org/springframework/gradle/github/release/GitHubReleasePlugin.java Outdated Show resolved Hide resolved
buildSrc/src/main/java/org/springframework/gradle/github/release/GitHubReleaseApi.java Outdated Show resolved Hide resolved
buildSrc/src/main/java/org/springframework/gradle/github/release/CreateGitHubReleaseTask.java Outdated Show resolved Hide resolved
buildSrc/src/main/java/org/springframework/gradle/github/release/RepositoryRef.java Outdated Show resolved Hide resolved
@sjohnr sjohnr force-pushed the gh-10457-github-release-plugin branch from 1105967 to c6c4817 Compare November 16, 2021 20:14
@sjohnr sjohnr force-pushed the gh-10457-github-release-plugin branch from c6c4817 to 2c952c4 Compare December 14, 2021 19:40
@sjohnr sjohnr requested a review from eleftherias December 14, 2021 19:59
@sjohnr
Copy link
Member Author

sjohnr commented Dec 14, 2021

@eleftherias, I have updated the PR, including adding additional options createRelease and branch, and made gitHubAccessToken optional with a check, so that we can test with dry runs. This task also tags the release, so it accomplishes both #10456 and #10457.

I've tested it and it's working well, so we should be able to begin work on automating releases in a pipeline. Let me know if you spot anything else.

@sjohnr sjohnr linked an issue Dec 14, 2021 that may be closed by this pull request
Automate tagging release version #10456
Closed
eleftherias
eleftherias suggested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment @sjohnr. In my option you can merge this after that change. I don't think another review is needed.

buildSrc/src/main/java/org/springframework/gradle/github/milestones/GitHubMilestonePlugin.java Show resolved Hide resolved
@sjohnr sjohnr force-pushed the gh-10457-github-release-plugin branch from 2c952c4 to 9deb1f1 Compare December 22, 2021 16:07
@sjohnr sjohnr merged commit ad90745 into spring-projects:main Dec 22, 2021
@sjohnr sjohnr deleted the gh-10457-github-release-plugin branch December 22, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias requested changes

Assignees

@sjohnr sjohnr

Labels
in: build An issue in the build status: duplicate A duplicate of another issue type: task A general task
Projects
None yet
Milestone
5.7.x
Development

Successfully merging this pull request may close these issues.

Automate creating github release Automate tagging release version
2 participants
@sjohnr @eleftherias