move HttpSecurityDsl and common files to annotation package #10474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: config
eleftherias
suggested changes
Nov 5, 2021
|
|
||
| import io.mockk.Called |
There was a problem hiding this comment.
Nice catch finding these unused imports @nor-ek!
Since this change is not related to resolving package tangles, please move it to a separate commit.
This will ensure the commit message accurately describes the changes.
There was a problem hiding this comment.
@eleftherias please check it out. I've noticed more changes like that and packed them into Import cleanup commit.
I've also cleaned up titles and messages.
jzheaux
added
the
type: breaks-passivity
spring-projectsgh-10333 move dsl files from org.springframework.security.config.web.servlet to org.springframework.security.config.annotation.web in tests and src.
spring-projectsgh-10333 remove unnecessary imports
nor-ek
force-pushed
the
gh-10333-clean
branch
from
6d95e94 to
d740ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to gh-10333 issue I've moved files from
org.springframework.security.config.web.servlettoorg.springframework.security.config.annotation.webinsrc/main/kotlin.Result after running
gradle check && gradle s101 | grep feedbackDependenciescommand