Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add saml2.ValidIssuers parameter into SAML 2.0 Assertion Validators #10341

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Add saml2.ValidIssuers parameter into SAML 2.0 Assertion Validators #10341

merged 1 commit into from
Oct 14, 2021

Conversation

marcusdacoregio
Copy link
Contributor

Adds the saml2.ValidIssuers parameter into SAML 2.0 Assertion Validators

Closes gh-10335

@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Oct 5, 2021
@marcusdacoregio marcusdacoregio added this to the 5.6.0-RC1 milestone Oct 5, 2021
@marcusdacoregio marcusdacoregio self-assigned this Oct 5, 2021
jzheaux
jzheaux requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marcusdacoregio! I've left some feedback inline.

...ork/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProviderTests.java Outdated Show resolved Hide resolved
...ramework/security/saml2/provider/service/authentication/OpenSaml4AuthenticationProvider.java Outdated Show resolved Hide resolved
@marcusdacoregio marcusdacoregio force-pushed the saml2-validissuers branch 2 times, most recently from f873986 to 401219c Compare October 14, 2021 11:47
@marcusdacoregio
Add saml2.ValidIssuers parameter
be1eea1 
Adds the saml2.ValidIssuers parameter into SAML 2.0 Assertion Validators

Closes spring-projectsgh-10335
@jzheaux jzheaux merged commit 00084cf into spring-projects:main Oct 14, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Oct 14, 2021

Thanks, @marcusdacoregio! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@marcusdacoregio marcusdacoregio

Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-RC1
Development

Successfully merging this pull request may close these issues.

Add saml2.ValidIssuers parameter into SAML 2.0 Assertion Validators
2 participants
@marcusdacoregio @jzheaux