MappedJwtClaimSetConverter#withDefaults doesn't remove claims from JWT as documented #10142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to null. This commit allows ClaimTypeConverter to overwrite and return claim with value converted to null. Closes spring-projects#10135
spring-projects-issues
added
the
status: waiting-for-triage
|
@fguenci Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
marcusdacoregio
added
in: oauth2
jzheaux
requested changes
Jul 27, 2021
There was a problem hiding this comment.
Thanks, @fguenci, this looks great! I've left some feedback inline to help with overall consistency with the rest of the codebase.
Also, in preparation for merging, will you please squash commits and format the final commit like so:
Title ~50 Characters or Less
Any additional description with a width of ~70 characters
Closes gh-10135
maybe something like this:
Preserve Null Claim Values
Closes gh-10135
If you like, you can find more details in the contributing guidelines.
...e/src/test/java/org/springframework/security/oauth2/jwt/MappedJwtClaimSetConverterTests.java
Show resolved
Hide resolved
...ore/src/main/java/org/springframework/security/oauth2/core/converter/ClaimTypeConverter.java
Show resolved
Hide resolved
|
@fguenci Thank you for signing the Contributor License Agreement! |
Prior to this commit ClaimTypeConverter returned the claims with the original value for all the claims with a null converted value. The changes allows ClaimTypeConverter to overwrite and return claims with converted value of null. Closes spring-projectsgh-10135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ClaimTypeConverter doesn't overwrite claim's value converted to null.
This commit allows ClaimTypeConverter to overwrite and return claim with
value converted to null.
Closes #10135